Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 14 -> main #1381

Merged
merged 4 commits into from
Mar 14, 2024
Merged

Merge 14 -> main #1381

merged 4 commits into from
Mar 14, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Mar 13, 2024

➡️ Forward port

Port sdf14 to main

Branch comparison: main...sdf14

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

@iche033 iche033 requested review from azeey and scpeters as code owners March 13, 2024 22:16
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Mar 13, 2024
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 95.45455% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 92.42%. Comparing base (b79abc4) to head (046fa8b).

Files Patch % Lines
src/ParserConfig.cc 33.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1381   +/-   ##
=======================================
  Coverage   92.42%   92.42%           
=======================================
  Files         134      134           
  Lines       17707    17751   +44     
=======================================
+ Hits        16365    16406   +41     
- Misses       1342     1345    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

include/sdf/ParserConfig.hh Outdated Show resolved Hide resolved
@iche033 iche033 force-pushed the merge_14_main_20240314 branch from 2a641cf to 046fa8b Compare March 14, 2024 00:05
@iche033 iche033 merged commit b04828d into main Mar 14, 2024
10 checks passed
@iche033 iche033 deleted the merge_14_main_20240314 branch March 14, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants