Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestions to diff_drive example #676

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Suggestions to diff_drive example #676

merged 2 commits into from
Dec 18, 2024

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Dec 16, 2024

🦟 Bug fix

Fixes #

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde
Suggestions to diff_drive example
9f4b1ce 
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde requested a review from caguero December 16, 2024 10:41
@ahcorde ahcorde self-assigned this Dec 16, 2024
@ahcorde ahcorde mentioned this pull request Dec 16, 2024
Merged
8 tasks
caguero
caguero approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me!

@caguero caguero merged commit 53cce42 into caguero/diff_drive_demo_v2 Dec 18, 2024
4 checks passed
@caguero caguero deleted the ahcorde/diff_drive_demo_v2 branch December 18, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caguero caguero caguero approved these changes

Assignees

@ahcorde ahcorde

Labels
None yet
Projects
Core development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahcorde @caguero