Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #652 #653

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Fix issue #652 #653

merged 1 commit into from
Nov 22, 2024

Conversation

caguero
Copy link
Contributor

@caguero caguero commented Nov 21, 2024

🦟 Bug fix

Fixes #652

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@caguero
Use member variables instead.
681c8d9 
Signed-off-by: Carlos Agüero <[email protected]>
@caguero caguero requested a review from ahcorde as a code owner November 21, 2024 20:36
@caguero
Copy link
Contributor Author

caguero commented Nov 21, 2024

@Amronos , could you give it a look please?

Amronos
Amronos approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@Amronos Amronos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahcorde ahcorde merged commit 5c1251a into ros2 Nov 22, 2024
6 checks passed
@ahcorde ahcorde deleted the caguero/fix_issue_652 branch November 22, 2024 08:51
@caguero
Copy link
Contributor Author

caguero commented Nov 22, 2024

https://github.com/Mergifyio backport jazzy

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 22, 2024 •
edited
Loading

backport jazzy

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 22, 2024
@caguero @mergify
Use member variables instead. (#653)
855a5c4 
Signed-off-by: Carlos Agüero <[email protected]>
(cherry picked from commit 5c1251a)
@mergify mergify bot mentioned this pull request Nov 22, 2024
Merged
8 tasks
ahcorde pushed a commit that referenced this pull request Nov 22, 2024
@mergify @caguero
Use member variables instead. (#653) (#655)
4b5f2ab 
Signed-off-by: Carlos Agüero <[email protected]>
(cherry picked from commit 5c1251a)

Co-authored-by: Carlos Agüero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amronos Amronos Amronos approved these changes

@ahcorde ahcorde ahcorde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Core development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in launch file using <gz_server>
3 participants
@caguero @ahcorde @Amronos