Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move gzserver logic to its action (backport #646) #649

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 21, 2024

🦟 Bug fix

Summary

In a similar way of #628, this patch refactors the way we are launching gzserver. Now the logic lives in the action and all the launch files use this action.

How to test it?

You can try checking these launch files:

ros2 launch ros_gz_sim gz_server.launch.py world_sdf_file:=shapes.sdf use_composition:=True create_own_container:=True
ros2 launch ros_gz_sim gz_server.launch world_sdf_file:=shapes.sdf use_composition:=True create_own_container:=True
ros2 launch ros_gz_sim ros_gz_sim.launch.py bridge_name:=ros_gz_bridge config_file:=/home/caguero/ros_gz_ws/src/ros_gz/ros_gz_bridge/test/config/full.yaml world_sdf_file:=empty.sdf use_composition:=True create_own_container:=True
ros2 launch ros_gz_sim ros_gz_sim.launch bridge_name:=ros_gz_bridge config_file:=/home/caguero/ros_gz_ws/src/ros_gz/ros_gz_bridge/test/config/full.yaml world_sdf_file:=empty.sdf use_composition:=True create_own_container:=True

And check that there are no errors during launch.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.


This is an automatic backport of pull request #646 done by [Mergify](https://mergify.com).

Signed-off-by: Carlos Agüero <[email protected]>
(cherry picked from commit 6bbb9e4)
@mergify mergify bot requested a review from ahcorde as a code owner November 21, 2024 13:02
@mergify mergify bot mentioned this pull request Nov 21, 2024
8 tasks
@caguero
Copy link
Contributor

caguero commented Nov 21, 2024

Please, do not merge until we clarify #650 .

@caguero
Copy link
Contributor

caguero commented Nov 22, 2024

Please, do not merge until we clarify #650 .

Good to go!

@ahcorde ahcorde merged commit a7355c9 into jazzy Nov 22, 2024
6 checks passed
@ahcorde ahcorde deleted the mergify/bp/jazzy/pr-646 branch November 22, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants