Refactor triggered_camera demo #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Agüero <[email protected]>
azeey
reviewed
Nov 13, 2024
Comment on lines
2
to
3
| - ros_topic_name: "/camera" | ||
| gz_topic_name: "/camera" |
There was a problem hiding this comment.
This can be simlpified
Suggested change
| - ros_topic_name: "/camera" | |
| gz_topic_name: "/camera" | |
| - topic_name: "/camera" |
There was a problem hiding this comment.
Simplified in 3c5d49b.
Comment on lines
6
to
7
| subscriber_queue: 5 | ||
| publisher_queue: 6 |
There was a problem hiding this comment.
Do we want to specify these for sure? Can we not just use the defaults?
There was a problem hiding this comment.
Removed in 3c5d49b.
| gz_type_name: "gz.msgs.Image" | ||
| subscriber_queue: 5 | ||
| publisher_queue: 6 | ||
| lazy: false |
There was a problem hiding this comment.
I don't think there's harm in making lazy=true.
Suggested change
| lazy: false | |
| lazy: true |
There was a problem hiding this comment.
Changed in 3c5d49b.
Signed-off-by: Carlos Agüero <[email protected]>
ahcorde
requested changes
Nov 25, 2024
Signed-off-by: Carlos Agüero <[email protected]>
ahcorde
requested changes
Dec 13, 2024
It's added in https://github.com/gazebosim/ros_gz/pull/634/files . They share the same |
ahcorde
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the
triggered_camerademo leveraging the latest improvements inros_gz.Summary
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.