Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor navsat demo #639

Merged
merged 4 commits into from
Dec 13, 2024
Merged

Refactor navsat demo #639

merged 4 commits into from
Dec 13, 2024

Conversation

caguero
Copy link
Contributor

@caguero caguero commented Nov 6, 2024

Refactors the navsat demo leveraging the latest improvements in ros_gz.

  • I replaced the previous launch file from Python to XML.

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@caguero caguero marked this pull request as ready for review November 22, 2024 20:41
@caguero caguero requested a review from ahcorde as a code owner November 22, 2024 20:41
ahcorde
ahcorde requested changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see the value in the rqt plugin

@caguero
Copy link
Contributor Author

caguero commented Dec 13, 2024

I can't see the value in the rqt plugin

Could you check again? It works for me:
Screenshot from 2024-12-13 15-39-59

@caguero caguero merged commit 8bfdad1 into ros2 Dec 13, 2024
5 checks passed
@caguero caguero deleted the caguero/navsat_demo_v2 branch December 13, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Core development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caguero @ahcorde