Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor magnetometer demo #638

Merged
merged 7 commits into from
Dec 13, 2024
Merged

Refactor magnetometer demo #638

merged 7 commits into from
Dec 13, 2024

Conversation

caguero
Copy link
Contributor

@caguero caguero commented Nov 6, 2024

Refactors the magnetomer demo leveraging the latest improvements in ros_gz.

  • I replaced the previous launch file from Python to XML.

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@caguero caguero marked this pull request as ready for review November 22, 2024 20:41
@caguero caguero requested a review from ahcorde as a code owner November 22, 2024 20:41
Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see the values in rqt_topic

@caguero
Copy link
Contributor Author

caguero commented Nov 25, 2024

I can't see the values in rqt_topic

Are you expanding the topic? It works for me...

Screenshot from 2024-11-25 19-03-36

Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I can see this trace

[component_container-1] (2024-12-13 16:33:46.234) [warning] [Magnetometer.cc:462] Failed to update Magnetometer sensor enity [16]. Spherical coordinates not set.
[component_container-1] (2024-12-13 16:33:46.234) [warning] [Magnetometer.cc:462] Failed to update Magnetometer sensor enity [16]. Spherical coordinates not set.
[component_container-1] (2024-12-13 16:33:46.234) [warning] [Magnetometer.cc:462] Failed to update Magnetometer sensor enity [16]. Spherical coordinates not set.
[component_container-1] (2024-12-13 16:33:46.234) [warning] [Magnetometer.cc:462] Failed to update Magnetometer sensor enity [16]. Spherical coordinates not set.
...

@ahcorde ahcorde enabled auto-merge (squash) December 13, 2024 18:43
@ahcorde ahcorde merged commit e1f578a into ros2 Dec 13, 2024
4 of 5 checks passed
@ahcorde ahcorde deleted the caguero/magnetometer_demo_v2 branch December 13, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants