Merge iron ➡️ jazzy #569
Merged
Merge iron ➡️ jazzy #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Benjamin Perseghetti <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
… (gazebosim#396) * Add missing rosidl_cmake dep to ros_gz_bridge (gazebosim#391) Signed-off-by: Yadunund <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> Signed-off-by: Michael Carroll <[email protected]> * Run fortress and garden against iron Signed-off-by: Michael Carroll <[email protected]> --------- Signed-off-by: Yadunund <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> Signed-off-by: Michael Carroll <[email protected]> Co-authored-by: Yadu <[email protected]> Co-authored-by: Chris Lalancette <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
This PR fixes an incorrect subscription on one of the demos. Running ``` ros2 launch ros_gz_sim_demos gpu_lidar_bridge.launch.py ``` causes rviz2 to crash and exit with the error: ``` rviz2-3] [rviz2-3] >>> [rcutils|error_handling.c:108] rcutils_set_error_state() [rviz2-3] This error state is being overwritten: [rviz2-3] [rviz2-3] 'create_subscription() called for existing topic name rt/lidar with incompatible type sensor_msgs::msg::dds_::PointCloud2_, at ./src/subscription.cpp:146, at ./src/rcl/subscription.c:108' [rviz2-3] [rviz2-3] with this new error message: [rviz2-3] [rviz2-3] 'invalid allocator, at ./src/rcl/subscription.c:218' [rviz2-3] [rviz2-3] rcutils_reset_error() should be called after error handling to avoid this. ``` This is due to an incorrect subscription on the part of the demo. This PR fixes it by getting a subscription to the right topic for the pointcloud display. (`lidar/points` instead of `lidar`). Was tested on garden + humble. Signed-off-by: Arjo Chakravarty <[email protected]>
This PR fixes an incorrect subscription on one of the demos. Running ``` ros2 launch ros_gz_sim_demos gpu_lidar_bridge.launch.py ``` causes rviz2 to crash and exit with the error: ``` rviz2-3] [rviz2-3] >>> [rcutils|error_handling.c:108] rcutils_set_error_state() [rviz2-3] This error state is being overwritten: [rviz2-3] [rviz2-3] 'create_subscription() called for existing topic name rt/lidar with incompatible type sensor_msgs::msg::dds_::PointCloud2_, at ./src/subscription.cpp:146, at ./src/rcl/subscription.c:108' [rviz2-3] [rviz2-3] with this new error message: [rviz2-3] [rviz2-3] 'invalid allocator, at ./src/rcl/subscription.c:218' [rviz2-3] [rviz2-3] rcutils_reset_error() should be called after error handling to avoid this. ``` This is due to an incorrect subscription on the part of the demo. This PR fixes it by getting a subscription to the right topic for the pointcloud display. (`lidar/points` instead of `lidar`). Was tested on garden + humble. Signed-off-by: Arjo Chakravarty <[email protected]> Co-authored-by: Arjo Chakravarty <[email protected]>
The ROS type for gz.msgs.NavSat messages should be **sensor_msgs/msg/NavSatFix** instead of **sensor_msgs/msg/NavSatFixed** Signed-off-by: Arjun K Haridas <[email protected]>
The ROS type for gz.msgs.NavSat messages should be **sensor_msgs/msg/NavSatFix** instead of **sensor_msgs/msg/NavSatFixed** Signed-off-by: Arjun K Haridas <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
[backport Humble] Added more topic to the bridge (gazebosim#422)
…im#414) Signed-off-by: Aditya Pande <[email protected]> Signed-off-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Aditya Pande <[email protected]>
…rt/411 [backport humble] Update README.md (gazebosim#411)
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
…/411 [backport iron] Update README.md (gazebosim#411)
…im#414) (gazebosim#426) Signed-off-by: Aditya Pande <[email protected]> Signed-off-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Aditya Pande <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Aditya Pande <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Aditya Pande <[email protected]>
…rt/417 [backport humble] SensorNoise msg bridging (gazebosim#417)
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
…/428 [backport iron] Add link to project template (gazebosim#428)
…rt/428 [backport humble] Add link to project template (gazebosim#428)
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Fix the branch name when checking out ros_gz otherwise `rosdep install -r --from-paths src -i -y --rosdistro humble` errors with incompatible versions. Additonally link to gazebosim#401 (comment) which allows compilation on Ubuntu 20.04 + ROS2 Humble + Ignition Fortress Signed-off-by: Samuel Seng <[email protected]>
Signed-off-by: ymd-stella <[email protected]> Co-authored-by: ymd-stella <[email protected]>
…gazebosim#504) Signed-off-by: Michael Carroll <[email protected]> Co-authored-by: Michael Carroll <[email protected]>
…gazebosim#505) Signed-off-by: Michael Carroll <[email protected]> Co-authored-by: Michael Carroll <[email protected]>
…gazebosim#507) Signed-off-by: Michael Carroll <[email protected]>
…gazebosim#506) Signed-off-by: Michael Carroll <[email protected]>
This copies the implementation from `gazebo_ros_paths.py` to provide a
way for packages to set resource paths from `package.xml`.
```
e.g. <export>
<gazebo_ros gazebo_model_path="${prefix}/models"/>
<gazebo_ros gazebo_media_path="${prefix}/models"/>
</export>
```
The value of `gazebo_model_path` and `gazebo_media_path` is appended to `GZ_SIM_RESOURCE_PATH`
The value of `plugin_path` appended to `GZ_SIM_SYSTEM_PLUGIN_PATH`
---------
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Kotochleb <[email protected]> Signed-off-by: Krzysztof Wojciechowski <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Kotochleb <[email protected]> Signed-off-by: Krzysztof Wojciechowski <[email protected]> Signed-off-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Krzysztof Wojciechowski <[email protected]>
Forward port of gazebosim#486 * Message and bridge for MaterialColor. This allows bridging MaterialColor from ROS to GZ and is important for allowing simulation users to create status lights. Signed-off-by: Benjamin Perseghetti <[email protected]>
Signed-off-by: wittenator <[email protected]>
…gazebosim#526) Signed-off-by: wittenator <[email protected]> Co-authored-by: wittenator <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
…im#537) Signed-off-by: Vincent Rousseau <[email protected]> Signed-off-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Rousseau Vincent <[email protected]>
…osim#538) Signed-off-by: Vincent Rousseau <[email protected]> Signed-off-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Rousseau Vincent <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Alaa El Jawad <[email protected]> Signed-off-by: wittenator <[email protected]> Co-authored-by: El Jawad Alaa <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Humble ➡️ Iron
Signed-off-by: Addisu Z. Taddese <[email protected]>
|
@Mergifyio update |
❌ Mergify doesn't have permission to updateFor security reasons, Mergify can't update this pull request. Try updating locally. |
ahcorde
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port
iron➡️jazzyBranch comparison: jazzy...iron
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)