Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update launch files with name parameter #556

Merged
merged 4 commits into from
May 31, 2024
Merged

Update launch files with name parameter #556

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ef08550
Updating launch files.
caguero May 31, 2024
9dc4f26
Name is required.
caguero May 31, 2024
1c15ff2
Required
caguero May 31, 2024
e3aa557
Restore
caguero May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ros_gz_bridge/launch/ros_gz_bridge.launch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
<launch>
<arg name="name" default="ros_gz_bridge" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a required argument, I.e, it should not have a default value. If we do want a default value, we should consider using anon

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made it required to avoid user errors. 9dc4f26

<arg name="config_file" default="" />
<arg name="container_name" default="ros_gz_container" />
<arg name="namespace" default="" />
<arg name="use_composition" default="False" />
<arg name="use_respawn" default="False" />
<arg name="log_level" default="info" />
<ros_gz_bridge
<ros_gz_bridge
name="$(var name)"
config_file="$(var config_file)"
container_name="$(var container_name)"
namespace="$(var namespace)"
Expand Down
4 changes: 3 additions & 1 deletion ros_gz_sim/launch/ros_gz_sim.launch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<launch>
<arg name="name" default="ros_gz_bridge" />
<arg name="config_file" default="" />
<arg name="container_name" default="ros_gz_container" />
<arg name="namespace" default="" />
Expand All @@ -13,7 +14,8 @@
container_name="$(var container_name)"
use_composition="$(var use_composition)">
</gz_server>
<ros_gz_bridge
<ros_gz_bridge
name="$(var name)"
config_file="$(var config_file)"
container_name="$(var container_name)"
namespace="$(var namespace)"
Expand Down
Loading