Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ign to gz #519

Merged
merged 2 commits into from
Mar 25, 2024
Merged

ign to gz #519

merged 2 commits into from
Mar 25, 2024

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Mar 25, 2024

🦟 Bug fix

Summary

Replace ign with gz

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde requested review from azeey and mjcarroll March 25, 2024 19:28
@ahcorde ahcorde self-assigned this Mar 25, 2024
ros_gz_bridge/README.md Outdated Show resolved Hide resolved
ros_gz_bridge/README.md Outdated Show resolved Hide resolved
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde
Copy link
Collaborator Author

ahcorde commented Mar 25, 2024

This is documentation, I will merge it

@ahcorde ahcorde merged commit 78a2d1c into ros2 Mar 25, 2024
3 of 7 checks passed
@ahcorde ahcorde deleted the ahcorde/rolling/ign_to_gz branch March 25, 2024 19:55
caguero pushed a commit that referenced this pull request Mar 29, 2024
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
ros2 run ros_ign parameter_bridge [...] # Will emit deprecation warning
ros2 run ros_gz parameter_bridge [...] # Will emit deprecation warning

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this got caught by a find replace?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants