Use resource_retriever in the bridge #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
ahcorde
requested changes
Mar 20, 2024
ros_gz_sim_demos/worlds/ros_gz.sdf
Outdated
| @@ -70,7 +70,7 @@ | |||
|
|
|||
| <plugin name="ros_gz_sim::ROSGzBridge" | |||
| filename="ros-gz-bridge-system"> | |||
| <config_file>package://ros_gz_sim_demos/config/full.yaml</config_file> | |||
| <config_file>package://ros_gz_bridge/config/full.yaml</config_file> | |||
There was a problem hiding this comment.
I think you moved this file to package://ros_gz_bridge/test/config/full.yaml, isn't it ?
There was a problem hiding this comment.
Thanks, updated in 9576d86.
Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
…osim/ros_gz into caguero/resource_retriever_rolling
ahcorde
approved these changes
Mar 22, 2024
caguero
added a commit
that referenced
this pull request
Mar 29, 2024
Signed-off-by: Carlos Agüero <[email protected]> Signed-off-by: Carlos Agüero <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: Carlos Agüero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
As suggested in #501, this patch updates the bridge to use the
resource_retrieverallowing the use ofpackage://andfile://.Test it
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.