-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conversion for geometry_msgs/msg/TwistStamped <-> gz.msgs.Twist #468
Conversation
Signed-off-by: Addisu Z. Taddese <[email protected]>
Can't comment on the technical completeness, but great to see! Is the plan to backport this to whatever is running on Humble / Iron today? |
Yes, I'll go ahead and backport it to the |
OK. Can you email me once this is in binaries for Rolling at the very least? |
This is excellent to see. This was one of the biggest risks to my choice to use TwistStamped in ArduPilot and NAV2 for our GSoC project. Thank you to everyone involved here in making this happen in ros_gz before the API freeze in J-Turtle. |
…gs.Twist (gazebosim#468) Signed-off-by: Addisu Z. Taddese <[email protected]>
…gs.Twist (gazebosim#468) Signed-off-by: Addisu Z. Taddese <[email protected]>
…gs.Twist (#468) (#470) Signed-off-by: Addisu Z. Taddese <[email protected]>
…gs.Twist (gazebosim#468) Signed-off-by: Addisu Z. Taddese <[email protected]>
…gs.Twist (#468) (#471) Signed-off-by: Addisu Z. Taddese <[email protected]>
Is there any plan for "gazebo_ros_pkgs/gazebo_plugins/src/gazebo_ros_planar_move.cpp" ? |
🎉 New feature
Summary
There's an effort to migrate to using
TwistStamped
forcmd_vel
messages (see ros-navigation/navigation2#1594). This PR adds a converter forgz.msgs.Twist
since it already has the header information (seetwist.proto
).I've also done some cleanup and regenerated the conversion table.
Test it
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.cc @SteveMacenski