Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[forward port Rolling] Added messages for 2D Bounding Boxes to ros_gz_bridge (#458) #466

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Nov 21, 2023

🎉 New feature

Summary

[forward port Rolling] Added messages for 2D Bounding Boxes to ros_gz_bridge (#458)

I added the bridging of Detection2D and Detection2DArray to AnnotatedAxisAligned2DBox and AnnotatedAxisAligned2DBox_V and vice versa.

Test it

WIP

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@ahcorde ahcorde requested a review from mjcarroll November 21, 2023 09:14
@ahcorde ahcorde self-assigned this Nov 21, 2023
@ahcorde ahcorde merged commit 04acbda into ros2 Nov 21, 2023
8 checks passed
@ahcorde ahcorde deleted the ahcorde/rolling/2d_bb branch November 21, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants