Skip to content

Commit

Permalink
Add a virtual destructor to suppress compiler warning (#502) (#504)
Browse files Browse the repository at this point in the history
Signed-off-by: Michael Carroll <[email protected]>
Co-authored-by: Michael Carroll <[email protected]>
  • Loading branch information
ahcorde and mjcarroll authored Feb 23, 2024
1 parent 6810c20 commit 8233fbd
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 0 deletions.
1 change: 1 addition & 0 deletions ros_gz_bridge/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ add_library(${bridge_lib}
src/bridge_handle_ros_to_gz.cpp
src/bridge_handle_gz_to_ros.cpp
src/factory_interface.cpp
src/service_factory_interface.cpp
src/service_factories/ros_gz_interfaces.cpp
src/ros_gz_bridge.cpp
${convert_files}
Expand Down
24 changes: 24 additions & 0 deletions ros_gz_bridge/src/service_factory_interface.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
// Copyright 2024 Open Source Robotics Foundation, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

#include "service_factory_interface.hpp"

namespace ros_gz_bridge
{

ServiceFactoryInterface::~ServiceFactoryInterface()
{
}

} // namespace ros_gz_bridge
2 changes: 2 additions & 0 deletions ros_gz_bridge/src/service_factory_interface.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ namespace ros_gz_bridge
class ServiceFactoryInterface
{
public:
virtual ~ServiceFactoryInterface() = 0;

virtual
rclcpp::ServiceBase::SharedPtr
create_ros_service(
Expand Down

0 comments on commit 8233fbd

Please sign in to comment.