-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Populate JointTransmittedWrench from physics #989
Conversation
@azeey , can you comment on the relation between this PR and: |
#952 populates forces in the DOF of the joint whereas this PR populates the constraint (non-DOF direction) wrench on the joint. This wrench will not (hopefully) include the commanded force in the DOF of the joint. #952 need gazebosim/gz-physics#143, which we're still trying to resolve. #977 I believe is the ign-gazebo counter part to the ign-sensors Force/Torque sensor. |
Signed-off-by: Addisu Z. Taddese <[email protected]>
1eaf18c
to
68dc519
Compare
Signed-off-by: Addisu Z. Taddese <[email protected]>
68dc519
to
b367494
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tried running it but the code and test looks reasonable to me.
Can we add unit tests for the component in test/integration/components.cc
? That would have caught the serialization typo
Signed-off-by: Addisu Z. Taddese <[email protected]>
@osrf-jenkins run test |
Looks like the |
Ahhhhh see gazebo-tooling/gzdev#35 |
@osrf-jenkins run tests please |
Codecov Report
@@ Coverage Diff @@
## main #989 +/- ##
==========================================
+ Coverage 63.40% 63.43% +0.03%
==========================================
Files 240 241 +1
Lines 19548 19577 +29
==========================================
+ Hits 12394 12419 +25
- Misses 7154 7158 +4
Continue to review full report at Codecov.
|
Signed-off-by: Addisu Z. Taddese <[email protected]> Signed-off-by: William Lew <[email protected]>
🎉 New feature
Summary
This populates joint constraint wrenches from ign-physics. This is needed to implement Force/Torque sensors.
Needs gazebosim/gz-physics#283
Test it
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge