Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix entity tree for large worlds #673

Merged
merged 1 commit into from
Mar 9, 2021
Merged

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Summary

Since #497 it's possible that plugins receive updates before any entity has been created. This happens for example for large worlds like tunnel.sdf, which take a while to load. This PR makes sure the tree keeps trying to get all entities until some are available.

To test it, run ign gazebo tunnel.sdf with and without this PR. Without this PR, the entity tree will be empty.

Checklist

  • Signed all commits for DCO
  • Added tests: no, tough to test large worlds that take time to load
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@chapulina chapulina added bug Something isn't working GUI Gazebo's graphical interface (not pure Ignition GUI) labels Mar 9, 2021
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Mar 9, 2021
@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #673 (37d85dc) into ign-gazebo3 (7d98df4) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo3     #673      +/-   ##
===============================================
- Coverage        77.88%   77.87%   -0.02%     
===============================================
  Files              210      210              
  Lines            11649    11650       +1     
===============================================
- Hits              9073     9072       -1     
- Misses            2576     2578       +2     
Impacted Files Coverage Δ
src/gui/plugins/entity_tree/EntityTree.cc 13.11% <50.00%> (-0.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d98df4...37d85dc. Read the comment docs.

@chapulina chapulina merged commit 6434c24 into ign-gazebo3 Mar 9, 2021
@chapulina chapulina deleted the chapulina/3/tree_update branch March 9, 2021 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🏰 citadel Ignition Citadel GUI Gazebo's graphical interface (not pure Ignition GUI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants