Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on gz-common graphics component #2105

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Aug 31, 2023

🎉 New feature

This will enable #2061 to get in after the Harmonic code freeze.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Nate Koenig <[email protected]>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Aug 31, 2023
@nkoenig nkoenig changed the base branch from gz-sim7 to main August 31, 2023 03:41
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #2105 (a84d66a) into main (2ae5eb0) will decrease coverage by 0.07%.
Report is 9 commits behind head on main.
The diff coverage is 58.05%.

❗ Current head a84d66a differs from pull request most recent head b2f2fb6. Consider uploading reports for the commit b2f2fb6 to get more accurate results

@@            Coverage Diff             @@
##             main    #2105      +/-   ##
==========================================
- Coverage   65.37%   65.31%   -0.07%     
==========================================
  Files         320      322       +2     
  Lines       30215    30435     +220     
==========================================
+ Hits        19754    19878     +124     
- Misses      10461    10557      +96     
Files Changed Coverage Δ
include/gz/sim/EventManager.hh 75.75% <ø> (ø)
python/src/gz/sim/Link.cc 50.00% <ø> (ø)
src/cmd/ModelCommandAPI.cc 0.00% <ø> (ø)
.../plugins/component_inspector/ComponentInspector.cc 5.57% <ø> (ø)
src/network/NetworkManagerPrimary.cc 79.46% <ø> (ø)
src/network/NetworkManagerSecondary.cc 81.53% <ø> (ø)
src/network/PeerInfo.hh 100.00% <ø> (ø)
...rc/systems/ackermann_steering/AckermannSteering.cc 80.18% <ø> (ø)
src/systems/diff_drive/DiffDrive.cc 83.81% <ø> (ø)
...rc/systems/odometry_publisher/OdometryPublisher.cc 88.08% <ø> (ø)
... and 16 more

... and 1 file with indirect coverage changes

@iche033 iche033 added 🎵 harmonic Gazebo Harmonic and removed 🌱 garden Ignition Garden labels Aug 31, 2023
@iche033 iche033 merged commit 469b8ce into main Aug 31, 2023
@iche033 iche033 deleted the nkoenig/common-graphics branch August 31, 2023 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants