Skip to content

Commit

Permalink
Use RTLD_NODELETE=true when loading libraries (#1649)
Browse files Browse the repository at this point in the history
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>

Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>
  • Loading branch information
azeey and chapulina authored Sep 1, 2022
1 parent 0942c2e commit ff1c82b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/SystemLoader.cc
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ class gz::sim::SystemLoaderPrivate
}
}

auto pluginNames = this->loader.LoadLib(pathToLib);
auto pluginNames = this->loader.LoadLib(pathToLib, true);
if (pluginNames.empty())
{
gzerr << "Failed to load system plugin [" << filename <<
Expand Down
4 changes: 1 addition & 3 deletions src/gui/Gui_clean_exit_TEST.cc
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,7 @@ void startBoth(const std::string &_fileName)
}

/////////////////////////////////////////////////
/// TODO (azeey) Temporarliy disabled until
/// https://github.com/gazebosim/gz-sim/issues/1443 is resolved
TEST_P(GazeboDeathTest, DISABLED_CleanExit)
TEST_P(GazeboDeathTest, GZ_UTILS_TEST_ENABLED_ONLY_ON_LINUX(CleanExit))
{
std::string githubAction;
// This test hangs when there is high CPU usage, so we skip it on Github
Expand Down

0 comments on commit ff1c82b

Please sign in to comment.