Skip to content

Commit

Permalink
Fix log playback GUI display (#2611)
Browse files Browse the repository at this point in the history
Loading the logging playback plugin before `SceneBroadcaster`
prevents playback from being displayed on the GUI.



---------

Signed-off-by: Addisu Z. Taddese <[email protected]>
Co-authored-by: Arjo Chakravarty <[email protected]>
  • Loading branch information
azeey and arjo129 authored Sep 12, 2024
1 parent b1f919b commit ca40c1d
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions src/SimulationRunner.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1596,8 +1596,6 @@ void SimulationRunner::CreateEntities(const sdf::World &_world)
this->entityCompMgr.ProcessRemoveEntityRequests();
this->entityCompMgr.ClearRemovedComponents();

this->LoadLoggingPlugins(this->serverConfig);

// Load any additional plugins from the Server Configuration
this->LoadServerPlugins(this->serverConfig.Plugins());

Expand Down Expand Up @@ -1653,6 +1651,11 @@ void SimulationRunner::CreateEntities(const sdf::World &_world)
}

this->LoadServerPlugins(defaultPlugins);
// Load logging plugins after all server plugins so that necessary
// plugins such as SceneBroadcaster are loaded first. This might be
// a bug or an assumption made in the logging plugins.
this->LoadLoggingPlugins(this->serverConfig);

};

// Store the initial state of the ECM;
Expand Down

0 comments on commit ca40c1d

Please sign in to comment.