Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable tests failing on arm64 #510

Merged
merged 2 commits into from
Sep 23, 2022
Merged

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Fixes #485 by disabling the failing portions of tests for arm64 architectures.

Summary

Some of the tests are failing that involve string comparisons of the output of stream operators with different levels of precision.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Some of the tests are failing that involve string
comparisons of the output of stream operators  with
different levels of precision.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters requested a review from j-rivero September 23, 2022 06:31
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Sep 23, 2022
@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Merging #510 (ea80930) into gz-math7 (56d7985) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           gz-math7     #510   +/-   ##
=========================================
  Coverage     99.70%   99.70%           
=========================================
  Files            77       77           
  Lines          7007     7007           
=========================================
  Hits           6986     6986           
  Misses           21       21           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mjcarroll mjcarroll merged commit 818ccf8 into gz-math7 Sep 23, 2022
@mjcarroll mjcarroll deleted the scpeters/arm64_failing_tests branch September 23, 2022 14:37
@j-rivero
Copy link
Contributor

Sorry to arrive a late. Although disabling the tests in other arches is the quickest way to have the software compiling I think it is not the best approach. For the two issues disabled here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants