Make API / naming consistent for Frustum, Edge, Angle #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Angle.cc fix gazebosim#301 Signed-off-by: Akshat Pandya <[email protected]>
1. DiffDriveOdometry.cc 2. DiffDriveOdometry.hh fix gazebosim#301 Signed-off-by: Akshat Pandya <[email protected]>
fix gazebosim#301 Signed-off-by: Akshat Pandya <[email protected]>
fix gazebosim#301 Signed-off-by: Akshat Pandya <[email protected]>
fix gazebosim#301 Signed-off-by: Akshat Pandya <[email protected]>
fix gazebosim#301 Signed-off-by: Akshat Pandya <[email protected]>
fix gazebosim#301 Signed-off-by: Akshat Pandya <[email protected]>
1. Angle.cc fix gazebosim#301 Signed-off-by: Akshat Pandya <[email protected]>
1. DiffDriveOdometry.cc 2. DiffDriveOdometry.hh fix gazebosim#301 Signed-off-by: Akshat Pandya <[email protected]>
fix gazebosim#301 Signed-off-by: Akshat Pandya <[email protected]>
fix gazebosim#301 Signed-off-by: Akshat Pandya <[email protected]>
fix gazebosim#301 Signed-off-by: Akshat Pandya <[email protected]>
fix gazebosim#301 Signed-off-by: Akshat Pandya <[email protected]>
fix gazebosim#301 Signed-off-by: Akshat Pandya <[email protected]>
…akshatpandya/api_consistent
Codecov Report
@@ Coverage Diff @@
## main #329 +/- ##
=======================================
Coverage 99.27% 99.27%
=======================================
Files 67 67
Lines 6077 6077
=======================================
Hits 6033 6033
Misses 44 44
Continue to review full report at Codecov.
|
chapulina
reviewed
Dec 27, 2021
fix gazebosim#301 Signed-off-by: Akshat Pandya <[email protected]>
…akshatpandya/api_consistent
|
Hi @chapulina I've made the change you mentioned. I'll move onto the remaining classes now. |
chapulina
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #301
Summary
Making API consistent. Removing const from POD. Making sure getters are const. Other styling changes according to style guide.
Classes updated: