Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds python interface for Kmeans and Vector3Stats #232

Merged
merged 4 commits into from
Sep 8, 2021

Conversation

WagnerMarcos
Copy link
Contributor

@WagnerMarcos WagnerMarcos commented Aug 30, 2021

🎉 New feature

Goes on top of #220

Related to #101 #210

Summary

Adds Python interface for two math classes: Kmeans and Vector3Stats. For each class a python test has been created.

Related issues and notes

Kmeans

  • For the bool Cluster(int _k, std::vector<Vector3d> &_centroids, std::vector<unsigned int> &_labels) method, that takes two output arguments, a struct was created to handle this return, as we haven't been able to handle output values using references in the arguments.
  • It is possible to use python lists to handle the observations.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@WagnerMarcos WagnerMarcos requested a review from scpeters as a code owner August 30, 2021 18:33
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels Aug 30, 2021
@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #232 (c793d31) into ign-math6 (4ac81c0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           ign-math6     #232   +/-   ##
==========================================
  Coverage      99.22%   99.22%           
==========================================
  Files             66       66           
  Lines           6162     6162           
==========================================
  Hits            6114     6114           
  Misses            48       48           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ac81c0...c793d31. Read the comment docs.

@francocipollone
Copy link
Contributor

It goes on top of PR #220

@francocipollone francocipollone changed the title Wagnermarcos/kmeans vector3 stats py interface Adds python interface for Kmeans and Vector3Stats Aug 30, 2021
@WagnerMarcos WagnerMarcos force-pushed the wagnermarcos/kmeans_vector3Stats_py_interface branch from c0f01b6 to b4531e2 Compare August 31, 2021 16:01
Copy link
Contributor

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chapulina chapulina added the beta Targeting beta release of upcoming collection label Sep 8, 2021
@scpeters scpeters merged commit b3804bf into ign-math6 Sep 8, 2021
@scpeters scpeters deleted the wagnermarcos/kmeans_vector3Stats_py_interface branch September 8, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants