-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds python interface for Kmeans and Vector3Stats #232
Adds python interface for Kmeans and Vector3Stats #232
Conversation
Codecov Report
@@ Coverage Diff @@
## ign-math6 #232 +/- ##
==========================================
Coverage 99.22% 99.22%
==========================================
Files 66 66
Lines 6162 6162
==========================================
Hits 6114 6114
Misses 48 48 Continue to review full report at Codecov.
|
It goes on top of PR #220 |
Signed-off-by: Marcos Wagner <[email protected]>
c0f01b6
to
b4531e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎉 New feature
Goes on top of #220
Related to #101 #210
Summary
Adds Python interface for two math classes: Kmeans and Vector3Stats. For each class a python test has been created.
Related issues and notes
Kmeans
bool Cluster(int _k, std::vector<Vector3d> &_centroids, std::vector<unsigned int> &_labels)
method, that takes two output arguments, a struct was created to handle this return, as we haven't been able to handle output values using references in the arguments.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge