Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps in garden : ign-garden #3

Closed
wants to merge 1 commit into from
Closed

Conversation

scpeters
Copy link
Member

Signed-off-by: Steve Peters <[email protected]>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Nov 17, 2021
@@ -15,15 +15,15 @@ repositories:
ign-gazebo:
type: git
url: https://github.com/ignitionrobotics/ign-gazebo
version: ign-gazebo6
version: ign-gazebo7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These could be main, but I think this file isn't used for anything, so this should be ok

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to see where this happens in bump_dependency.bash...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a blind search-and-replace. I don't think it's worth "fixing"... We often forget to flip from main to release branches after the official release, so maybe it's good to be this way from the start

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the homebrew formula test checks that all the branches exist: https://github.com/osrf/homebrew-simulation/blob/master/Formula/ignition-garden.rb#L55-L58

so that may fail until we create the release branches

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh gotcha, yeah then we need to fix this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to close this and test an improved script to see if that can get it right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants