Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak ros2_overview tutorial. #531

Merged
merged 8 commits into from
Oct 31, 2024
Merged

Tweak ros2_overview tutorial. #531

merged 8 commits into from
Oct 31, 2024

Conversation

caguero
Copy link
Contributor

@caguero caguero commented Oct 22, 2024

🦟 Bug fix

This patch fixes one typo and the figure (the parameter values were wrong). Thanks @azeey for catching it.

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Oct 22, 2024
@caguero caguero requested a review from azeey October 22, 2024 13:58
azeey
azeey reviewed Oct 22, 2024
View reviewed changes
Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @caguero. One other thing I noticed on the image on the right is that it's not clear that Gazebo and the bridge are running in the same container and nav2 is running outside of that container. Could you add something to the graphics to group Gazebo and the bridge together?

@caguero
Copy link
Contributor Author

caguero commented Oct 22, 2024

Thanks @caguero. One other thing I noticed on the image on the right is that it's not clear that Gazebo and the bridge are running in the same container and nav2 is running outside of that container. Could you add something to the graphics to group Gazebo and the bridge together?

The intent of the right image is to show that the three nodes can be running within the same process. However, we're not starting the container ourselves..

@azeey
Copy link
Contributor

azeey commented Oct 25, 2024

I see. Should we have a separate diagram to show Gazebo and bridge in the same container and the consumer ROS node be a separate process? I think that's the most common use case.

Amronos added a commit to Amronos/gazebosim-docs that referenced this pull request Oct 25, 2024
@Amronos
Undo changes made to comopsition_options.png
00fb07c 
Has been done in gazebosim#531

Signed-off-by: Aarav Gupta <[email protected]>
azeey pushed a commit that referenced this pull request Oct 28, 2024
@Amronos
Composition and Bridge Updates (#528)
4f93d11 
* Composition and Bridge Updates

Signed-off-by: Aarav Gupta <[email protected]>

* Update composition_options.png

Signed-off-by: Aarav Gupta <[email protected]>

* Add documentation for spawning a model alongside launch ros_gz_bridge

Signed-off-by: Aarav Gupta <[email protected]>

* Undo changes made to comopsition_options.png

Has been done in #531

Signed-off-by: Aarav Gupta <[email protected]>

---------

Signed-off-by: Aarav Gupta <[email protected]>
Signed-off-by: Aarav Gupta <[email protected]>
@caguero
Updated composition figure and text
e83899c 
Signed-off-by: Carlos Agüero <[email protected]>
@caguero
Cropped image
b348015 
Signed-off-by: Carlos Agüero <[email protected]>
@caguero
Copy link
Contributor Author

caguero commented Oct 30, 2024

I see. Should we have a separate diagram to show Gazebo and bridge in the same container and the consumer ROS node be a separate process? I think that's the most common use case.

Thanks for the suggestions. Updated diagram and text added in e83899c.

azeey
azeey reviewed Oct 31, 2024
View reviewed changes
harmonic/ros2_overview.md Outdated Show resolved Hide resolved
harmonic/ros2_overview.md Outdated Show resolved Hide resolved
caguero and others added 2 commits October 31, 2024 20:07
@caguero @azeey
Update harmonic/ros2_overview.md
39ec0bb 
Co-authored-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
@caguero @azeey
Update harmonic/ros2_overview.md
2e62144 
Co-authored-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
@caguero caguero merged commit 62539cf into master Oct 31, 2024
5 checks passed
@caguero caguero deleted the caguero/tweak_composition_tutorial branch October 31, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@azeey azeey azeey approved these changes

@mabelzhang mabelzhang Awaiting requested review from mabelzhang mabelzhang is a code owner

Assignees
No one assigned
Labels
🎵 harmonic Gazebo Harmonic
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caguero @azeey @ahcorde