-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OIDC deploy #450
OIDC deploy #450
Conversation
Signed-off-by: Crola1702 <[email protected]>
Signed-off-by: Crola1702 <[email protected]>
Signed-off-by: Crola1702 <[email protected]>
Signed-off-by: Crola1702 <[email protected]>
Signed-off-by: Crola1702 <[email protected]>
Signed-off-by: Crola1702 <[email protected]>
Signed-off-by: Crola1702 <[email protected]>
Signed-off-by: Crola1702 <[email protected]>
Signed-off-by: Crola1702 <[email protected]>
Signed-off-by: Crola1702 <[email protected]>
Signed-off-by: Crola1702 <[email protected]>
Signed-off-by: Crola1702 <[email protected]>
Signed-off-by: Crola1702 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@azeey Are we deploying the acropolis or blueprint docs still?
I assume this is asking about the workflow changed in this PR. We're currently only building the non-EOL releases, so no, we're not deploying acropolis and blueprint. However, the last built documentation is still accessible. For example, the gz-sim API docs from blueprint are at https://gazebosim.org/api/sim/2/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
However, this workflow will likely become obsolete when #441 is finished and merged.
🎉 New feature
OIDC deploy for gz-docs
Summary
This PR implements OIDC authorization for AWS deploys, so we don't use hardcoded credentials but a single role
Test it
Github action run: https://github.com/gazebosim/docs/actions/runs/9391710482
CC: @claraberendsen
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.