Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDC deploy #450

Merged
merged 13 commits into from
Jun 13, 2024
Merged

OIDC deploy #450

merged 13 commits into from
Jun 13, 2024

Conversation

Crola1702
Copy link
Contributor

@Crola1702 Crola1702 commented Jun 5, 2024

🎉 New feature

OIDC deploy for gz-docs

Summary

This PR implements OIDC authorization for AWS deploys, so we don't use hardcoded credentials but a single role

Test it

Github action run: https://github.com/gazebosim/docs/actions/runs/9391710482

CC: @claraberendsen

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@Crola1702 Crola1702 requested review from azeey and Blast545 June 5, 2024 21:54
@Crola1702 Crola1702 self-assigned this Jun 5, 2024
Copy link

@claraberendsen claraberendsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@azeey Are we deploying the acropolis or blueprint docs still?

@Crola1702
Copy link
Contributor Author

Crola1702 commented Jun 11, 2024

@azeey Are we deploying the acropolis or blueprint docs still?\

Friendly ping @azeey

@azeey
Copy link
Contributor

azeey commented Jun 13, 2024

@azeey Are we deploying the acropolis or blueprint docs still?

I assume this is asking about the workflow changed in this PR. We're currently only building the non-EOL releases, so no, we're not deploying acropolis and blueprint. However, the last built documentation is still accessible. For example, the gz-sim API docs from blueprint are at https://gazebosim.org/api/sim/2/

Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
However, this workflow will likely become obsolete when #441 is finished and merged.

@Crola1702 Crola1702 merged commit 83227ce into master Jun 13, 2024
3 checks passed
@Crola1702 Crola1702 deleted the Crola1702/oidc-deploy branch June 13, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants