Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python3-distutils to IGN_MATH_DEPENDENCIES #621

Closed
wants to merge 1 commit into from

Conversation

j-rivero
Copy link
Contributor

@j-rivero j-rivero commented Jan 5, 2022

Should fix problems on CI in gazebosim/gz-math#360

Tested Build Status

@chapulina
Copy link
Contributor

Thanks! I added that to ign-math's packages.apt together with the rest of dependencies in gazebosim/gz-math#360. That's a better place for it since it's used by GitHub actions, tutorials, etc.

@scpeters
Copy link
Contributor

scpeters commented Jan 6, 2022

Thanks! I added that to ign-math's packages.apt together with the rest of dependencies in ignitionrobotics/ign-math#360. That's a better place for it since it's used by GitHub actions, tutorials, etc.

agreed. I proposed moving away from storing dependency information in dependencies_archive.sh in #619 since it is easier to express the logic for different versions and OS combinations with the packages.apt files

@j-rivero
Copy link
Contributor Author

j-rivero commented Jan 7, 2022

agreed. I proposed moving away from storing dependency information in dependencies_archive.sh in #619 since it is easier to express the logic for different versions and OS combinations with the packages.apt files

ack. I think that we have discussed this in the past, moving dependencies to a more distributed approach could be easier to manage in the short term but it comes with the cost of increasing maintenance effort for changing affecting multiple versions. No silver bullet here.

Do we have a tracking issue to check the status of the migration effort?

@chapulina
Copy link
Contributor

I think that we have discussed this in the past

I think this issue is related, I'll add a comment there: #190

@j-rivero
Copy link
Contributor Author

@j-rivero j-rivero closed this Apr 19, 2022
@scpeters scpeters deleted the python3_release branch November 19, 2022 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants