Install dependencies defined on packages.apt file in source code #317
Conversation
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
|
how do you feel about re-adding #305 into this PR so we can test that it's working? |
|
I like storing this metadata in the repository much better than in |
|
This branch doesn't include #316 , so the test mentioned above is still at a state where #305 was in: https://build.osrfoundation.org/job/ignition_fuel-tools-ci-pr_any-ubuntu_auto-amd64/431/console I'll add those changes here again just in case. |
|
Updated this branch and reverted #316 . Triggered new build for gazebosim/gz-transport#188, which this is meant to fix: |
Just saw you said a bunch, so here we go:
|
|
ok, I should have said, "let's test all the dome jobs whose build scripts were affected by #305", so the ign-transport build is a good one, but I'd like to test the others too. I'll start them and post build badges |
|
Related tickets: #190 / gazebo-tooling/action-gz-ci#15 / #316
All Ignition libraries now have
.github/ci/package*.aptfiles in their source code defining all their debian dependencies. An elaborate example isign-gazebo, which has 3 packages files:packages.aptfor dependencies common to all platformspackages-bionic.aptfor dependencies specific to Bionicpackages-focal.aptfor dependencies specific to FocalThese files are being used by the GitHub actions CI in https://github.com/ignition-tooling/action-ignition-ci , and we can use them here too. Having these files living next to the source code make it easier to update dependencies at the same time as the source code changes.
Nothing is broken if a library doesn't have
packages.aptfiles.This was tested here, see how the packages listed here ended up in the
PACKAGES_CACHE_AND_CHECK_UPDATESvariable.With this change, I think we don't need to keep dependencies_archive.sh updated whenever dependencies are added to Ignition libraries anymore? Not sure if that's used for something other than CI.