Added log.py and implemented logging functionality #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankitxjoshi
requested changes
Apr 8, 2018
| def setup_custom_logger(name): | ||
| logger = logging.getLogger(__name__) | ||
| logger.setLevel(logging.DEBUG) | ||
| formatter = logging.Formatter('%(asctime)s:%(levelname)s:%(name)s:%(message)s') |
There was a problem hiding this comment.
Line length exceeds 79. Pep8 violation 😸
|
|
||
| while True: # STT Loop | ||
| audio = recognizer.listen(source) # listen from mic | ||
|
|
||
| try: | ||
| text = recognizer.recognize_google(audio) # recognize with google | ||
| logging.info("You said:") | ||
| logging.info(text) | ||
| logger.info("You said:") |
There was a problem hiding this comment.
concatenate You said with the text.
|
Not necessary but FYI short-log should be in present imperative tense and not in past tense. Plus adding a link to the issue the PR is referencing is also a good practice. |
|
Ok sir , will do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.