Add support for ExternalRecorder channelscan #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented the LoadChannels, FirstChannel and NextChannel commands of the ExternalRecorder protocol so that the ExternalRecorder can do a channel scan. The myththdhrrecorder did already read the channel lineup from the HDHomeRun but previously, to get the channel information in MythTV it needed to be entered manually with mythtv-setup. The code is tested with the HDHomeRun HDHR3-4DC for DVB-C and with the HDHR5-2DT for DVB-T2. The ExternalRecorder asks for a callsign but there is no callsign available in the channel lineup so the channel name is used here as well. There will be some changes needed to support not only DVB but also ATSC because of the major_minor channel number and the callsign.
|
Thank you! I used this with a new HDHR Flex and it worked great! |
|
Used this with HDHR3-CC's and it works perfectly. Fastest channel scan of my life! |
No functional changes.
|
I just pushed a commit to MythTV master which allows this patch to work correctly with ATSC channels. Thank you Klaas, this is very useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the LoadChannels, FirstChannel and NextChannel commands of
the ExternalRecorder protocol so that the ExternalRecorder can do a channel scan.
The myththdhrrecorder did already read the channel lineup from the HDHomeRun but previously,
to get the channel information in MythTV it needed to be entered manually with mythtv-setup.
The code is tested with the HDHomeRun HDHR3-4DC for DVB-C and with the HDHR5-2DT for DVB-T2.
The ExternalRecorder asks for a callsign but there is no callsign available
in the channel lineup so the channel name is used here as well.
There will be some changes needed to support not only DVB but also ATSC because
of the major_minor channel number and the callsign.