Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CustomJsonLd for carousel #949

Merged
merged 11 commits into from
Oct 28, 2023

Conversation

mkaynakk
Copy link
Contributor

@mkaynakk mkaynakk commented Apr 12, 2022

Description of Change(s):

Hi,

Optional properties can be added and the type of items can be customized in carousel.

Why was it needed?

  • An item's type is 'VideoGame, MusicRecording' etc. can be a value. So the type can be set.
  • Position information can continue instead of being reset when the page changes.

Related Document
https://schema.org/ItemList (Example 3)

Test

  • Have you updated the documentation to go with your changes? Yes
  • Have you written or updated unit tests? Yes

All tests are passing.

Thanks for your work :)

@mkaynakk
Copy link
Contributor Author

mkaynakk commented May 1, 2022

any news? @garmeeh

@jwilson114
Copy link

Very much needed.

@garmeeh
Copy link
Owner

garmeeh commented Jul 20, 2022

Hey @mkaynakk sorry about the delay.

What is the use case for this?

Wondering should we add url also to the item?

@mkaynakk
Copy link
Contributor Author

It can be used on pages in a numerical incremental pagination structure. A url information can be passed at the beginning of the page, and I think this will be sufficient. @garmeeh

@kjprince
Copy link

kjprince commented Jun 9, 2023

Can we merge this change? Would be great to use this for blog category pages as shown here:
https://webmasters.stackexchange.com/questions/119808/schema-org-structured-data-for-blog-category-page

README.md Outdated Show resolved Hide resolved
@garmeeh garmeeh merged commit ae7923d into garmeeh:master Oct 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants