-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add the assign method to RawCoMap to create bulk transactions and optimize RawCoMap init #1077
Open
gdorsi
wants to merge
1
commit into
main
Choose a base branch
from
perf-bulk-operations
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+58
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gdorsi
force-pushed
the
perf-bulk-operations
branch
from
December 20, 2024 23:55
fc52479
to
61517b4
Compare
gdorsi
force-pushed
the
perf-bulk-operations
branch
from
December 20, 2024 23:58
61517b4
to
4a4d7f2
Compare
…nd optimize RawCoMap init
gdorsi
force-pushed
the
perf-bulk-operations
branch
from
December 23, 2024 10:09
4a4d7f2
to
1ef3226
Compare
gdorsi
changed the title
perf: Optimize RawCoMap and RawCoList init and add methods to create bulk transactions
feat: add the assign method to RawCoMap to create bulk transactions and optimize RawCoMap init
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding more operations in a single transaction helps us on optimize the encrypt/decrypt/sign/veirfy operations by having a single payload to handle instead of many.
In this PR we are adding a new method to RawCoMap to perform set operations in bulk and used assign to optimize the RawCoMap init
The performance gain depends on the size of the payload, but we can see some improvements even with small datasets