Implement clearer syntax for deep loading #1018
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
11 Skipped Deployments
|
aeplay
force-pushed
the
jazz-581-rfc-new-deep-loading-api
branch
from
6c39be0 to
6a8fa16
Compare
gdorsi
reviewed
Dec 17, 2024
| ): { me: Acc | DeeplyLoaded<Acc, D> | undefined; logOut: () => void } { | ||
| function useAccount<const O extends { resolve?: RefsToResolve<Acc> }>( | ||
| options: O, | ||
| ): { me: Resolved<Acc, O> | undefined; logOut: () => void }; |
There was a problem hiding this comment.
This kind of typing makes ok to add new options like:
Do you think it would be ok to have just:
useAccount<const R extends RefsToResolve<Acc>>(
options: { resolve?: R },
): { me: Resolved<Acc, R> | undefined; logOut: () => void };There was a problem hiding this comment.
Also noticed that with this change it would be possible to add docs on the resolve option:
There was a problem hiding this comment.
Noticed two other issues:
- Additional properties added inside to resolve aren't marked as invalid
- Errors on the value side are quite cryptic
We probably can't do much to make errors easier to read, but we should definitely mark additional properties as errors.
See:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.