Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel: simplify 'print path' handling #5850

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fingolfin
Copy link
Member

No need for a complex dispatch setup when there really are only two cases to be handled.

Also remove some HPC-GAP specific code -- since the ObjectsModuleState is stored in thread local storage anyway, there is no need to dynamically allocate part of it.

No need for a complex dispatch setup when there really are only two cases
to be handled.

Also remove some HPC-GAP specific code -- since the ObjectsModuleState is
stored in thread local storage anyway, there is no need to dynamically
allocate part of it.
@fingolfin
Copy link
Member Author

BTW this was sparked by @ThomasBreuer discovering some oddity with invoking certain printing methods in isolation, which failed... because they called SET_PRINT_OBJ_INDEX (like here) which is only possible if they are called from the GAP kernel functions triggering printing. Ah well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant