-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow packages to omit AvailabilityTest
in their PackageInfo.g
#5832
Allow packages to omit AvailabilityTest
in their PackageInfo.g
#5832
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change from lib/grpfpiso.gi
should better be proposed in another pull request.
Concerning the failures because some AvailabilityTest
functions return something different from true
or false
, eventually the functions should be fixed, but for the moment we can continue accepting these results.
d4e6a82
to
13c516a
Compare
@ThomasBreuer fixed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Now just the outputs tested in tst/testinstall/package.tst
must be adjusted:
The line complaining about the missing AvailabilityTest
must be removed from the output of ValidatePackageInfo(rec());
.
Perhaps also the AvailabilityTest
components can be removed from the later info
records (or perhaps be replaced by a non-function).
If missing we assume it is ReturnTrue which is what >= 100 of our packages use.
13c516a
to
768ed9a
Compare
Adjusted the validator tests as suggested, and then cleaned them up a bit more for good measure. |
AvailabilityTest
in their PackageInfo.g
If missing we assume it is ReturnTrue which is what >= 100 of our packages use.