Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow packages to omit AvailabilityTest in their PackageInfo.g #5832

Merged

Conversation

fingolfin
Copy link
Member

If missing we assume it is ReturnTrue which is what >= 100 of our packages use.

@fingolfin fingolfin added the topic: packages issues or PRs related to package handling, or specific to a package (for packages w/o issue tracker) label Nov 1, 2024
Copy link
Contributor

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change from lib/grpfpiso.gi should better be proposed in another pull request.

Concerning the failures because some AvailabilityTest functions return something different from true or false, eventually the functions should be fixed, but for the moment we can continue accepting these results.

lib/gpfpiso.gi Outdated Show resolved Hide resolved
lib/package.gi Outdated Show resolved Hide resolved
@fingolfin
Copy link
Member Author

@ThomasBreuer fixed now

Copy link
Contributor

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
Now just the outputs tested in tst/testinstall/package.tst must be adjusted:
The line complaining about the missing AvailabilityTest must be removed from the output of ValidatePackageInfo(rec());.
Perhaps also the AvailabilityTest components can be removed from the later info records (or perhaps be replaced by a non-function).

@fingolfin
Copy link
Member Author

Adjusted the validator tests as suggested, and then cleaned them up a bit more for good measure.

@ThomasBreuer ThomasBreuer merged commit 1c45e6f into gap-system:master Nov 8, 2024
33 checks passed
@fingolfin fingolfin changed the title Make AvailabilityTest for packages optional Allow packages to omit AvailabilityTest in their PackageInfo.g Nov 13, 2024
@fingolfin fingolfin added topic: library release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: library topic: packages issues or PRs related to package handling, or specific to a package (for packages w/o issue tracker)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants