Ensure JSON encoding supports non-ASCII characters in uploads

[arash77]

Update JSON encoding in upload requests to handle non-ASCII characters correctly.
Fixes step 2 of #18584

How to test the changes?

(Select all options that apply)

• I've included appropriate automated tests.
• This is a refactoring of components with existing test coverage.
• Instructions for manual testing are as follows:
  1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

• I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

[arash77]

@galaxyproject/wg-backend Should this be applied to all json.dump(s)?

[mvdbeek]

Can you add a test please ?
In what circumstances does the load not restore the unicode string ?

In [1]: import json

In [2]: json.loads(json.dumps("💩", ensure_ascii=True))
Out[2]: '💩'

[arash77]

Can you add a test please ? In what circumstances does the load not restore the unicode string ?

In [1]: import json

In [2]: json.loads(json.dumps("💩", ensure_ascii=True))
Out[2]: '💩'

The problem here is mostly visual, so for example when we export the history we have datasets_attrs.txt or history_attrs.txt file that is not the loaded json and will not include the correct characters!
This also happens in request_json in tool parameters.

[mvdbeek]

I don't think we should deviate from stdlib defaults for this. If python decides they're done with that practice then we'll get the new defaults, but I don't think cosmetic changes to files that are not meant for human consumption warrants this.

[arash77]

Ok.
Even the name variable in here?

[mvdbeek]

I mean, should users see this at all ? Probably not ? And if so it should probably be rendered as json, not as a string ?

[arash77]

If this is the case, then I close the PR.