async triggers #348
Merged
async triggers #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #348 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 349 342 -7
Branches 61 51 -10
=========================================
- Hits 349 342 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
gagoar
commented
Jan 25, 2021
|
|
||
| module.exports = { | ||
| globals: { | ||
| "ts-jest": { | ||
| 'ts-jest': { |
gagoar
commented
Jan 25, 2021
| collectCoverage: true, | ||
| collectCoverageFrom: ["src/*.ts", "!./index.ts"], | ||
| coverageDirectory: "./coverage/", | ||
| collectCoverageFrom: ['src/*.ts', '!./index.ts', '!src/rules.guard.ts'], |
There was a problem hiding this comment.
we don't want to collect coverage from an autogenerated file.
gagoar
commented
Jan 25, 2021
| @@ -102,7 +102,6 @@ | |||
| "author": "Gago <[email protected]>", | |||
| "dependencies": { | |||
| "@actions/core": "1.2.6", | |||
| "@github/memoize": "^1.0.1", | |||
There was a problem hiding this comment.
we have the actual files instead of the library anyway.
gagoar
commented
Jan 25, 2021
| @@ -137,6 +136,7 @@ | |||
| "prettier-eslint": "12.0.0", | |||
| "prettier-eslint-cli": "5.0.0", | |||
| "pretty-quick": "3.1.0", | |||
| "ts-auto-guard": "1.0.0-alpha.13", | |||
There was a problem hiding this comment.
this is what I've used to generate the type guards
gagoar
force-pushed
the
gg/async-triggers
branch
from
c263e75 to
5c45e0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Reference: #213
Description
all triggers are now async by default.
Motivation and Context
As a step to enable #346 and keep refactoring without changing functionality for #213 I've made all. the interfaces for the triggers be async.
note: Sadly I couldn't replace as much code as I wanted with the generated guards. but this will be solved when we are able to refactor the rules shape.
for now, we will have to keep the function
isValidRawRulearound given that it is more expressive than the ones autogenerated.How Has This Been Tested?
unit tests.
Checklist: