Skip to content

Commit

Permalink
add TODO:s
Browse files Browse the repository at this point in the history
  • Loading branch information
igagis committed Nov 13, 2024
1 parent 794f96f commit c178e17
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/ruis/render/scene/gltf_loader.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -341,12 +341,15 @@ utki::shared_ref<node> gltf_loader::read_node(const jsondom::value& json_node)

// TODO: support loading "matrix"

// TODO: check if "mesh" is present before reading it
int mesh_index = read_int(json_node, "mesh");
// TODO: check if mesh_index is within the this->meshes array

child_indices.push_back(read_uint_array(json_node, "children"));

return utki::make_shared<node>(
std::move(name), //
mesh_index >= 0 ? meshes[mesh_index].to_shared_ptr() : nullptr,
mesh_index >= 0 ? this->meshes[mesh_index].to_shared_ptr() : nullptr,
std::move(transformation)
);
}
Expand Down

0 comments on commit c178e17

Please sign in to comment.