Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue for destroying node #270

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PankajJatav
Copy link
Contributor

Hi Gadicc,

Thanks for designing the grate package for meteor + famous.
While working this package I found that

"While moving form one route to other routes (or page). Basically your package delete root node of that page and children, sub-children and so on.But I found issue in node deleting method. That only delete odd number of child of a node.
Let me explain by an example let suppose i have a node with 5 children, children info save in a array. So when destroy method delete child one, then all children index rearrange in array from 0 to 3. Now while deleting second child it's delete the child whose index 1(third child) and so on and all even number of child remain in DOM."

Please check it and let me know you thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant