component attrUpdate number fix; camera depth test

gadicc · Jun 10, 2015 · b142d4b · b142d4b
1 parent 08f46e9
commit b142d4b
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 0 deletions.
diff --git a/HISTORY.md b/HISTORY.md
@@ -1,5 +1,12 @@
 ## vNEXT
 
+## v1.2.0
+
+* Components [Cc]olor attributes
+* Mesh glossiness attribute
+* Internal "fvClass" -> "_class"; store classes in FView._classes
+* Warn if dev puts more than 1 node inside of famousEach
+
 ## v1.1.0
 
 * Fix for Famous 0.5.2 (and further work on DOMElement handling)

diff --git a/lib/wrappers/Components.js b/lib/wrappers/Components.js
@@ -45,6 +45,7 @@ var ComponentClass = FView._classes._Component = {
       /*
        * Action necessary for object values too
        */
+      newValue = value;
 
     }
 

diff --git a/package.js b/package.js
@@ -75,6 +75,7 @@ Package.onTest(function(api) {
     'tests/wrappers/Nodes/Scene.html',
     'tests/wrappers/Nodes/Scene.js',
     'tests/wrappers/Components.js',
+    'tests/wrappers/Components/Camera.js',
     'tests/wrappers/Components/Mesh.js',
     'tests/wrappers/Components/DOMElement.html',
     'tests/wrappers/Components/DOMElement.js',

diff --git a/tests/wrappers/Components/Camera.js b/tests/wrappers/Components/Camera.js
@@ -0,0 +1,19 @@
+/*
+ * Like Components [cC]olor, but with "; strength"
+ */
+Tinytest.add('famous-views - Wrappers - Components - Camera - depth', function(test) {
+  var expectedDepth;
+
+  var cdata = {
+    instance: {
+      setDepth: function(depth) {
+        test.equal(typeof depth, "number");
+        test.equal(depth, expectedDepth);
+      }
+    }
+  };
+
+  expectedDepth = 1000;
+  FView._classes.Camera.attrUpdate('depth', 1000, null, null, null, cdata);
+  FView._classes.Camera.attrUpdate('depth', "1000", null, null, null, cdata);
+});
-Original file line number
+Diff line change
@@ Expand Up / @@ -45,6 +45,7 @@ var ComponentClass = FView._classes._Component = { @@
           /*
            * Action necessary for object values too
            */
+          newValue = value;
         }
@@ Expand Down @@