jpass- Adds user-selected language feature #32

edimoral · 2024-03-10T02:30:27Z

This PR introduces:

Updates GUI when user selects a language
Stores the language selected in jpass.properties file
Sets JFileChooser CANCEL button based on language selected
Updates README.md file
Adds UTs to increase code coverage

…cted

edimoral · 2024-03-10T02:31:32Z

src/main/java/jpass/ui/JPassFrame.java

@@ -215,7 +258,7 @@ private JPassFrame(String fileName, Locale locale) {

        setJMenuBar(this.jpassMenuBar);
        setDefaultCloseOperation(WindowConstants.DO_NOTHING_ON_CLOSE);
-        setSize(450, 400);
+        setSize(490, 400);


@gaborbata Increases width to allow long string for some JMenu to be displayed. Let me know what you think about this.

Looks good, however it can be a bit wider (plese check with other languages).

edimoral · 2024-03-10T02:32:55Z

src/main/resources/resources/languages/languages_hu_HU.properties

@@ -1,6 +1,7 @@
 menuBar.fileMenu=Fájl
 menuBar.editMenu=Szerkesztés
 menuBar.toolsMenu=Eszközök
+menuBar.settingsMenu=Settings


@gaborbata can you also please help to translate these to Hungarian language?

Sure, it is called Beállítások in Hungarian

edimoral · 2024-03-10T02:33:56Z

src/main/resources/resources/languages/languages_it_IT.properties

@@ -87,3 +90,9 @@ panel.save=Salva
 panel.open=Apri
 panel.saveModifiedQuestionMessage=Il file attuale è stato modificato.\nVuoi salvare le modifiche prima della chiusura?
 panel.unencryptedDataWarningMessage=Nota che tutti i dati verranno archiviati non crittografati.\nAssicurati di conservare il file esportato in un luogo sicuro.
+
+language.languageChanged=Language has changed successfully.


@bovirus If you have some time, can you please suggest the correct translation to Italian for these strings added?

language.languageChanged=Impostazione lingua completata.

Thanks for the input, @bovirus . Can you also please check the other new strings added to this file?

@edimoral

Where can I get the latest Italian language (i see until line 89)?

edimoral · 2024-03-10T02:34:57Z

src/main/java/jpass/util/Configuration.java

@@ -98,6 +101,20 @@ public String get(String key, String defaultValue) {
        return properties.getProperty(key, defaultValue);
    }

+    public void set(String key, String value) {
+        properties.setProperty(key, value);
+        saveProperties();


I've added the feature to stores the user-selected language hence next time JPass is opened up will be using the language selected. Let me know what you think about this.

For me is ok.

Looks good. Unfortunately, comments are not saved.

edimoral · 2024-03-10T02:36:32Z

src/main/java/jpass/ui/JPassFrame.java

+        SUPPORTED_LANGUAGES.forEach((key, value) -> {
+            JMenuItem language = new JMenuItem(localizedMessages.getString(key));
+            if (Objects.equals(getCurrentLanguage(), value)) {
+                language.setIcon(getIcon("check_mark"));


I've added two new icons. Let me know if these ones are ok or what should be the process to add new ones.

For me is ok.

Hey @edimoral, could you please use symbolic icons from https://github.com/elementary/icons ?

Also, please make sure every icon has two versions in the resources:

one without a postfix e.g. world.svg with fill color fill='#666' (this is for the light theme)

one with the _dark postfix e.g. world_dark.svg with fill color fill='#999' (this is for dark theme)

gaborbata · 2024-03-10T06:52:49Z

Thanks for your changes, I'll review them in the following weeks (depending on job activities).

edimoral · 2024-03-12T08:00:09Z

src/main/resources/resources/languages/languages_it_IT.properties

@@ -2,6 +2,7 @@
 menuBar.fileMenu=File
 menuBar.editMenu=Modifica
 menuBar.toolsMenu=Strumenti
+menuBar.settingsMenu=Settings


@bovirus here

edimoral · 2024-03-12T08:00:17Z

src/main/resources/resources/languages/languages_it_IT.properties

@@ -35,6 +36,8 @@ editMenu.findEntry=Trova elemento

 toolsMenu.generatePassword=Genera password...

+settingsMenu.language=Language


@bovirus here

edimoral · 2024-03-12T08:00:52Z

src/main/resources/resources/languages/languages_it_IT.properties

@@ -87,3 +90,9 @@ panel.save=Salva
 panel.open=Apri
 panel.saveModifiedQuestionMessage=Il file attuale è stato modificato.\nVuoi salvare le modifiche prima della chiusura?
 panel.unencryptedDataWarningMessage=Nota che tutti i dati verranno archiviati non crittografati.\nAssicurati di conservare il file esportato in un luogo sicuro.
+
+language.languageChanged=Language has changed successfully.
+language.en.us=Inglese


And those from L:95 to L:98
@bovirus here

@edimoral

I didn't see this line (n. 95) in

src/main/resources/resources/languages/languages_it_IT.properties

The file has 89 lines.

gaborbata · 2024-03-18T12:32:26Z

src/main/java/jpass/ui/JPassFrame.java

@@ -232,8 +275,13 @@ public static JPassFrame getInstance() {

    public static synchronized JPassFrame getInstance(String fileName) {
        if (instance == null) {
-            String languageTag = Configuration.getInstance().get("language.languageSetting", "en-US");
-            instance = new JPassFrame(fileName, Locale.forLanguageTag(languageTag));
+            String languageTag = Configuration.getInstance().get(LANGUAGE_LANGUAGE_SETTING, null);


Why don't you simply use Configuration.getInstance().get(LANGUAGE_LANGUAGE_SETTING, "en-US") here?

gaborbata · 2024-03-18T12:39:47Z

src/main/resources/resources/languages/languages_en_US.properties

@@ -87,3 +90,9 @@ panel.save=Save
 panel.open=Open
 panel.saveModifiedQuestionMessage=The current file has been modified.\nDo you want to save the changes before closing?
 panel.unencryptedDataWarningMessage=Please note that all data will be stored unencrypted.\nMake sure you keep the exported file in a secure location.
+
+language.languageChanged=Language has changed successfully.
+language.en.us=English


I don't think it is a good idea to store language names in language resources. Every time a new translation in introduced, then all the resources need to be updated. Maybe it would be better to hard-code them in the supported languages map.

edimoral added 12 commits March 5, 2024 14:56

Initial commit

e70ea23

Adding supported languages dinamically

ed274b7

Adding constants and first working version

dede15d

Adds refresh method

5c9e9d0

Sets en-US as default

411b4e1

Updates GUI when user selects a language

9583a46

Sets new icon. Sets JFileChooser CANCEL button based on language sele…

7deb07e

…cted

Updates README.md

2b82846

Completes user-selected language implementation

b3c5f7b

Localizes language.languageChanged string

4042ed8

Adds UT for language

d811540

Adds UTs for increasing Jacoco Coverage

7a668d6

edimoral commented Mar 10, 2024

View reviewed changes

edimoral commented Mar 12, 2024

View reviewed changes

gaborbata reviewed Mar 18, 2024

View reviewed changes

gaborbata added the enhancement label Apr 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

jpass- Adds user-selected language feature #32

jpass- Adds user-selected language feature #32

edimoral commented Mar 10, 2024 •

edited

Loading

edimoral Mar 10, 2024

gaborbata Mar 18, 2024

edimoral Mar 10, 2024

gaborbata Mar 18, 2024

edimoral Mar 10, 2024

bovirus Mar 11, 2024

edimoral Mar 11, 2024

bovirus Mar 12, 2024

edimoral Mar 10, 2024

bovirus Mar 11, 2024

gaborbata Mar 18, 2024

edimoral Mar 10, 2024

bovirus Mar 11, 2024

gaborbata Mar 18, 2024

gaborbata commented Mar 10, 2024

edimoral Mar 12, 2024

edimoral Mar 12, 2024

edimoral Mar 12, 2024

bovirus Mar 13, 2024

gaborbata Mar 18, 2024

gaborbata Mar 18, 2024

		@@ -35,6 +36,8 @@ editMenu.findEntry=Trova elemento

		toolsMenu.generatePassword=Genera password...

		settingsMenu.language=Language

jpass- Adds user-selected language feature #32

Are you sure you want to change the base?

jpass- Adds user-selected language feature #32

Conversation

edimoral commented Mar 10, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gaborbata commented Mar 10, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

edimoral commented Mar 10, 2024 •

edited

Loading