Skip to content

Commit

Permalink
final fixes, ticking version numbers
Browse files Browse the repository at this point in the history
  • Loading branch information
gaasedelen committed Feb 5, 2024
1 parent 84eeb21 commit eeb16a5
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 2 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,7 @@ Lighthouse will remember your theme preference for future loads and uses.

Time and motivation permitting, future work may include:

* Nag Vector35 to fix HLIL highlighting ([bug](https://github.com/Vector35/binaryninja-api/issues/2584)) in Binary Ninja
* ~~Asynchronous composition, painting, metadata collection~~
* ~~Multifile/coverage support~~
* Profiling based heatmaps/painting
Expand Down
8 changes: 7 additions & 1 deletion plugins/lighthouse/integration/binja_integration.py
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,12 @@ def _open_coverage_overview(self, context):
return
super(LighthouseBinja, self).open_coverage_overview(dctx)

def _stub(self, context):
# XXX: This was added as a last minute bodge prior to releasing v0.9.3,
# it fixes a crash-on-close that was manifesting on binja macOS, when
# using a lambda instead of a concrete function/stub like this.
return None

#--------------------------------------------------------------------------
# Binja Actions
#--------------------------------------------------------------------------
Expand All @@ -235,7 +241,7 @@ def _install_load_batch(self):
def _install_open_coverage_xref(self):
action = self.ACTION_COVERAGE_XREF
UIAction.registerAction(action)
UIActionHandler.globalActions().bindAction(action, UIAction(lambda context: None, self._interactive_coverage_xref))
UIActionHandler.globalActions().bindAction(action, UIAction(self._stub, self._interactive_coverage_xref))
Menu.mainMenu("Plugins").addAction(action, "Loading", 2)

# NOTE/V35: Binja automatically creates View --> Show Coverage Overview
Expand Down
2 changes: 1 addition & 1 deletion plugins/lighthouse/integration/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class LighthouseCore(object):
# Plugin Metadata
#--------------------------------------------------------------------------

PLUGIN_VERSION = "0.9.3-RC"
PLUGIN_VERSION = "0.9.3"
AUTHORS = "Markus Gaasedelen"
DATE = "2024"

Expand Down

0 comments on commit eeb16a5

Please sign in to comment.