Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: update gks-common / vrs models #453

Merged
merged 11 commits into from
Oct 30, 2024
Merged

feat!: update gks-common / vrs models #453

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
96211e7
feat!: update gks-common / vrs models
korikuzma Sep 11, 2024
ec8fd40
pull in latest changes
korikuzma Sep 27, 2024
b5f4505
create base classes for stmt + study result
korikuzma Oct 1, 2024
5ebca83
rm unnecessary abc + dont make class private
korikuzma Oct 1, 2024
7d79121
add schema tests + fix extension required props
korikuzma Oct 10, 2024
0c3d349
more tests for descriptions
korikuzma Oct 11, 2024
9cab291
Revert "rm unnecessary abc + dont make class private"
korikuzma Oct 28, 2024
8632858
Merge branch 'main' into issue-452
korikuzma Oct 28, 2024
9123010
remove duplicate test module
korikuzma Oct 29, 2024
9e78fca
ruff cleanup
korikuzma Oct 29, 2024
f870cce
Merge branch 'main' into issue-452
korikuzma Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions src/ga4gh/core/domain_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,4 @@
"""GKS Common Library Domain Entity models

**This module should not be imported directly.**

Instead, users should use one of the following:

* `from ga4gh.core import domain_models`, and refer to models with the
abbreviated name, e.g., `domain_models.Gene` (recommended)

* `import ga4gh.core`, and refer to models using the fully-qualified
module name, e.g., `ga4gh.core.domain_models.Gene`
"""
"""GKS Common Library Domain Entity models"""
from enum import Enum
from typing import Literal, Union, List

Expand Down Expand Up @@ -138,5 +127,5 @@ class Gene(DomainEntity):

type: Literal["Gene"] = Field(
CommonDomainType.GENE.value,
description=f'MUST be "{CommonDomainType.GENE.value}".'
description=f'MUST be "{CommonDomainType.GENE.value}"'
)
Loading