Skip to content

Commit

Permalink
removing the schema deparser changes
Browse files Browse the repository at this point in the history
The `beacon_yaml2md.pl` doc generator contains hard coded definitions to VRS 1.2 `CopyNumber` which doesn't exist in 1.3.

This should be fixed separately, possibly w/ revision of the schema documentation method/engine.
  • Loading branch information
mbaudis committed Nov 16, 2024
1 parent c634b81 commit b1f81dc
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions bin/beacon_yaml2md.pl
Original file line number Diff line number Diff line change
Expand Up @@ -729,9 +729,9 @@ sub add_properties_vrs {
my ( $property, $data ) = @_;
my %url = (
'SequenceExpression' =>
'https://w3id.org/ga4gh/schema/vrs/1.3/vrs.json#/definitions/',
'https://w3id.org/ga4gh/schema/vrs/1.2/vrs.json#/definitions/',
'CopyNumber' =>
'https://w3id.org/ga4gh/schema/vrs/1.3/vrs.json#/definitions/'
'https://w3id.org/ga4gh/schema/vrs/1.2/vrs.json#/definitions/'
);
if ( exists $url{$property} ) {
$data->{properties} =
Expand Down
2 changes: 1 addition & 1 deletion bin/deref_schemas/obj/CopyNumber.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
---
CopyNumber:
properties: '[VRS definition for CopyNumber](https://w3id.org/ga4gh/schema/vrs/1.3/vrs.json#/definitions/CopyNumber)'
properties: '[VRS definition for CopyNumber](https://w3id.org/ga4gh/schema/vrs/1.2/vrs.json#/definitions/CopyNumber)'
type: allOf
2 changes: 1 addition & 1 deletion docs/schemas-md/obj/CopyNumber.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
|Term | Description | Type | Properties | Example | Enum|
| ---| ---| ---| ---| ---| --- |
| CopyNumber | NA | allOf | [VRS definition for CopyNumber](https://w3id.org/ga4gh/schema/vrs/1.3/vrs.json#/definitions/CopyNumber) | NA | NA|
| CopyNumber | NA | allOf | [VRS definition for CopyNumber](https://w3id.org/ga4gh/schema/vrs/1.2/vrs.json#/definitions/CopyNumber) | NA | NA|

2 comments on commit b1f81dc

@mrueda
Copy link
Collaborator

@mrueda mrueda commented on b1f81dc Nov 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbaudis Would it make sense for me to handle changes related to the yaml2md parser, re-run it, and ensure it covers this and other updates in models/examples? I can then open a PR if that works for you. What do you think?

I am always watching. :-)

@mbaudis
Copy link
Member Author

@mbaudis mbaudis commented on b1f81dc Nov 17, 2024 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.