fix: xero export settings payload bug

[JustARatherRidiculouslyLongUsername]

Description

The export settings PUT payload always sent the default option for ccc export date type, spent_at. As a result, the CCC export date type could never be changed. This change fixes the incorrect field reference that caused it.

Clickup

app.clickup.com

Summary by CodeRabbit

• New Features

  • Updated the export date type retrieval for credit card exports to enhance accuracy in data handling.

• Bug Fixes

  • Corrected the source of the export date type to ensure proper functionality in the export settings.

[coderabbitai]

Walkthrough

The changes involve a modification to the constructPayload method in the XeroExportSettingModel class, specifically updating how the ccc_export_date_type property is set within the expense_group_settings object. The source of this property has been changed from cccExportDate to creditCardExportDate, which impacts the payload construction to ensure the correct export date type is used.

Changes

File Path	Change Summary
src/app/core/models/xero/xero-configuration/xero-export-settings.model.ts	Updated constructPayload method to change source of ccc_export_date_type from cccExportDate to creditCardExportDate.

Suggested labels

deploy

Suggested reviewers

• DhaaraniCIT
• ashwin1111

Poem

In the meadow where bunnies play,
A change was made, hip-hip-hooray!
The date now flows from credit's grace,
A brighter path, a smoother pace.
With every hop, we celebrate,
The code evolves, it’s truly great! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 67a5817 and 5246594.

📒 Files selected for processing (1)

• src/app/core/models/xero/xero-configuration/xero-export-settings.model.ts (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• src/app/core/models/xero/xero-configuration/xero-export-settings.model.ts

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (1)

src/app/core/models/xero/xero-configuration/xero-export-settings.model.ts (1)

218-218: Remove trailing comma for consistency.

There's an unnecessary trailing comma that should be removed to maintain consistent code style.

-        ccc_export_date_type: exportSettingsForm.get('creditCardExportDate')?.value ? exportSettingsForm.get('creditCardExportDate')?.value : ExportDateType.SPENT_AT,
+        ccc_export_date_type: exportSettingsForm.get('creditCardExportDate')?.value ? exportSettingsForm.get('creditCardExportDate')?.value : ExportDateType.SPENT_AT

🧰 Tools

🪛 GitHub Check: lint

[failure] 218-218:
Unexpected trailing comma

🪛 eslint

[error] 218-218: Unexpected trailing comma.

(comma-dangle)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 57ec045 and 67a5817.

📒 Files selected for processing (1)

• src/app/core/models/xero/xero-configuration/xero-export-settings.model.ts (1 hunks)

🧰 Additional context used

🪛 GitHub Check: lint

src/app/core/models/xero/xero-configuration/xero-export-settings.model.ts

[failure] 218-218:
Unexpected trailing comma

🪛 eslint

src/app/core/models/xero/xero-configuration/xero-export-settings.model.ts

[error] 218-218: Unexpected trailing comma.

(comma-dangle)

[github-actions]

Unit Test Coverage	%	values
Statements	35.36%	( 4219 / 11929 )
Branches	28.99%	( 1227 / 4232 )
Functions	27.93%	( 934 / 3344 )
Lines	35.5%	( 4145 / 11676 )