Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frankification and various cleanups #52

Merged
merged 11 commits into from
Nov 12, 2024
Merged

Frankification and various cleanups #52

merged 11 commits into from
Nov 12, 2024

Conversation

xFrednet
Copy link
Collaborator

Major changes:

  • Renamed binary to frankenscript
  • Changed test file endings to .frank
  • Changed mermaid to use light theme by default
  • Renamed try_close() -> is_closed()
  • Added option to draw regions as trees instead of nested subgraphs

Based on #48
cc: @TobiasWrigstad

@xFrednet xFrednet requested a review from mjp41 November 12, 2024 14:17
@xFrednet xFrednet mentioned this pull request Nov 12, 2024
Closed
mjp41
mjp41 approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@mjp41 mjp41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Nov 12, 2024
Closed
Open
@xFrednet xFrednet merged commit e970086 into main Nov 12, 2024
5 checks passed
@xFrednet xFrednet deleted the 48-frankification branch November 12, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjp41 mjp41 mjp41 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xFrednet @mjp41 @TobiasWrigstad