Refactoring #37
Merged
Refactoring #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xFrednet
approved these changes
Oct 25, 2024
| void add_reference(DynObject* src, DynObject* target); | ||
| void remove_reference(DynObject* src_initial, DynObject* old_dst_initial); | ||
| void move_reference(DynObject* src, DynObject* dst, DynObject* target); | ||
| void create_region(DynObject* object); |
There was a problem hiding this comment.
It seems weird to me, that this takes a DynObject and returns void. Is this just temporary to get these refactorings in?
There was a problem hiding this comment.
Yeah, I was trying not to change stuff in the refactoring. So the next commit can actually update stuff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves a bunch of code out of DynObject that is related to the region management.
It also restricts the parent pointing references to a single incoming reference from the enclosing region. This is on the way to adding the explicit bridge object.