Skip to content

Commit

Permalink
Fix shard summary
Browse files Browse the repository at this point in the history
The summary should contain all failing targets when platforms are sharded, not necessarily when the failing test has been sharded.

Fixes bazelbuild#2046
  • Loading branch information
fweikert committed Oct 1, 2024
1 parent d7dd72e commit 164f451
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions buildkite/bazelci.py
Original file line number Diff line number Diff line change
Expand Up @@ -3854,8 +3854,6 @@ def print_shard_summary():

if test_execution.overall_status == "PASSED":
continue
if len(test_execution.shards) == 1:
continue

failures.append(
test_execution.Format(test_artifact.job_id, test_artifact.is_windows)
Expand Down

0 comments on commit 164f451

Please sign in to comment.