Skip to content

Commit

Permalink
Merge pull request #6 from fverdugo/bugfix_parallel_ksp
Browse files Browse the repository at this point in the history
Preserving ownership while destroying KspMPISetup
  • Loading branch information
fverdugo authored Feb 28, 2024
2 parents a74322d + f466db4 commit b553a03
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 3 deletions.
12 changes: 11 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,17 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [0.1.0] - Unreleased
## [0.1.1] - 2024-02-28

### Fixed

- Bugs in KSP solver wrapper.

### Added

- More methods to the low-level API.

## [0.1.0] - 2024-01-27

### Added

Expand Down
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "PetscCall"
uuid = "1194c000-87c4-4102-b4a0-a6217ec4849e"
authors = ["Francesc Verdugo <[email protected]> and contributors"]
version = "0.1.0"
version = "0.1.1"

[deps]
Libdl = "8f399da3-3557-5675-b5ff-fb832c97cbdb"
Expand Down
4 changes: 3 additions & 1 deletion src/ksp.jl
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,9 @@ end

function ksp_finalize!(setup::KspMPISetup)
if ! setup.user_handles
ksp_destroy_handles!(setup.handles)
ownership = setup.ownership
handles = setup.handles
GC.@preserve ownership ksp_destroy_handles!(handles)
end
nothing
end
Expand Down

2 comments on commit b553a03

@fverdugo
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/101876

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.1.1 -m "<description of version>" b553a0350606a6d31a58132a13afc5d8205ac9f7
git push origin v0.1.1

Please sign in to comment.