Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCG benchmark #177

Merged
merged 32 commits into from
Oct 24, 2024
Merged

HPCG benchmark #177

merged 32 commits into from
Oct 24, 2024

Conversation

HRvanElderen
Copy link
Contributor

HPCG benchmark package.
Added gauss_seidel_sweep_zero! and additive_schwarz_correction_partition to PartitionedSolvers.
There should not be any changes to PartitionedArrays.

Copy link
Owner

@fverdugo fverdugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @HRvanElderen

thanks for the PR.

See my comments.

You have re-formatted/re-indented many files, some of which should not contain actual changes. Please, edit the files so that you modify only the lines really needed.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
HPCG/test/hpcg_benchmark_tests.jl Outdated Show resolved Hide resolved
PartitionedSolvers/Project.toml Show resolved Hide resolved
PartitionedSolvers/src/smoothers.jl Outdated Show resolved Hide resolved
PartitionedSolvers/src/smoothers.jl Outdated Show resolved Hide resolved
PartitionedSolvers/src/smoothers.jl Outdated Show resolved Hide resolved
PartitionedSolvers/src/smoothers.jl Show resolved Hide resolved
src/p_sparse_matrix.jl Outdated Show resolved Hide resolved
src/sparse_utils.jl Outdated Show resolved Hide resolved
@fverdugo
Copy link
Owner

@HRvanElderen The code looks much better now! But tests are failing.

@HRvanElderen
Copy link
Contributor Author

@fverdugo Tests should be working now, except the tests in HPCG that require the new functions in PartitionedSolvers.

@fverdugo
Copy link
Owner

@fverdugo Tests should be working now, except the tests in HPCG that require the new functions in PartitionedSolvers.

The HPCG tests should work the commit version of PartitionedSolvers, not the registered version. See e.g., how I am using the commit version of PartitionedArrays when testing PartitionedSolvers:

Pkg.develop(path=".")

For HPCG you should add something like

Pkg.develop(path=".")
Pkg.develop(path="./PartitionedSolvers")

around here

https://github.com/HRvanElderen/PartitionedArrays.jl/blob/d551b870eb2b85e59000e3b82c6d73a45dc34b73/.github/workflows/ci.yml#L88

@fverdugo fverdugo merged commit 2c9f414 into fverdugo:master Oct 24, 2024
5 checks passed
@fverdugo
Copy link
Owner

@HRvanElderen Thanks for this nice addition. In a separate one, we will document how to use the benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants