This repository has been archived by the owner on Mar 31, 2023. It is now read-only.
[Node Manager] Junit test with MockIgniteServer #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nju/macmanager
…nju/macmanager
kimeunju108
requested review from
xieus,
cathyhongzhang and
kevin-zhonghao
and removed request for
cathyhongzhang
xieus
changed the title
xieus
approved these changes
May 17, 2020
| import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.*; | ||
| import static org.springframework.test.web.servlet.result.MockMvcResultHandlers.print; | ||
| import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status; | ||
|
|
||
| @RunWith(SpringRunner.class) | ||
| @SpringBootTest() | ||
| @AutoConfigureMockMvc | ||
| public class NodeControllerTest { | ||
| public class NodeControllerTest extends MockIgniteServer { |
There was a problem hiding this comment.
I don't think the node manager UTs currently need MockIgniteServer as it doesn't have real e2e test cases. But it is okay to add in advance so that you could add more e2e UTs in the future.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR show the following changes: